Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-102799: use sys.exception() instead of sys.exc_info() in tests #103293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 6, 2023
Merged

gh-102799: use sys.exception() instead of sys.exc_info() in tests #103293

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
77ec662
test_exceptions
iritkatriel Apr 5, 2023
5641d25
test_generators 1
iritkatriel Apr 5, 2023
612be88
test_generators 2
iritkatriel Apr 5, 2023
6d9da09
test_asyncio, test_class, test_logging
iritkatriel Apr 5, 2023
93fb191
test_ssl, test/profilee
iritkatriel Apr 5, 2023
ccfb27f
test/support/asycore, test_(c)profile
iritkatriel Apr 5, 2023
a5a78c2
test_traceback
iritkatriel Apr 5, 2023
eb54ba5
test_asyncio
iritkatriel Apr 5, 2023
4737b82
check exact type
iritkatriel Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_asyncio
  • Loading branch information
@iritkatriel
iritkatriel committed Apr 5, 2023
commit eb54ba5f316bbd6981c5325bedd0bdf9557be7d6
2 changes: 1 addition & 1 deletion Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ def on_timeout():
if (
timed_out
and task.uncancel() == 0
and sys.exc_info()[0] is asyncio.CancelledError
and isinstance(sys.exception(), asyncio.CancelledError)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add the isinstance() call? The original test insists that you get exactly CancelledError. I think that's useful to test for, since not all cancellation code is resilient to subclasses of CancelledError.

(In other cases below I don't mind.)

):
# Note the five rules that are needed here to satisfy proper
# uncancellation:
Expand Down