Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-103472: close response in HTTPConnection._tunnel #103473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 8 commits into from
May 2, 2023
Merged

GH-103472: close response in HTTPConnection._tunnel #103473

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
86952ce
GH-103472: close response in HTTPConnection._tunnel
graingert Apr 12, 2023
6508762
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 12, 2023
f88793c
Update Misc/NEWS.d/next/Library/2023-04-12-13-04-16.gh-issue-103472.C…
graingert Apr 12, 2023
959db96
Merge branch 'main' into close-response-in-http-client-tunnel
graingert Apr 25, 2023
5500734
Merge branch 'main' into close-response-in-http-client-tunnel
graingert Apr 25, 2023
2aa460c
test that HTTPConnection._tunnel closes the response on exceptions
graingert Apr 25, 2023
c2171c7
minor wording and ReST update to NEWS
gpshead May 2, 2023
bd079b1
word wrap news.
gpshead May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test that HTTPConnection._tunnel closes the response on exceptions
  • Loading branch information
@graingert
graingert committed Apr 25, 2023
commit 2aa460c4986f4f9961206ef0b50ed85e48eb4298
23 changes: 23 additions & 0 deletions Lib/test/test_httplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,6 +2390,29 @@ def test_tunnel_debuglog(self):
lines = output.getvalue().splitlines()
self.assertIn('header: {}'.format(expected_header), lines)

def test_tunnel_leak(self):
sock = None

def _create_connection(address, timeout=None, source_address=None):
nonlocal sock
sock = FakeSocket(
'HTTP/1.1 404 NOT FOUND\r\n\r\n',
host=address[0],
port=address[1],
)
return sock

self.conn._create_connection = _create_connection
self.conn.set_tunnel('destination.com')
Comment thread
gpshead marked this conversation as resolved.
exc = None
try:
self.conn.request('HEAD', '/', '')
except OSError as e:
# keeping a reference to exc keeps response alive in the traceback
exc = e
self.assertIsNotNone(exc)
self.assertTrue(sock.file_closed)


if __name__ == '__main__':
unittest.main(verbosity=2)