Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-103743: Add PyUnstable_Object_GC_NewWithExtraData #103744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 9 commits into from
May 2, 2023
Merged

gh-103743: Add PyUnstable_Object_GC_NewWithExtraData #103744

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d644206
gh-103743: Add PyUnstable_Object_GC_NewWithExtraData (#103743)
jbradaric Apr 24, 2023
14975c0
Merge branch 'main' into jbradaric/obj-new-with-extra-data
ambv Apr 25, 2023
52135dc
Don't suggest PEP 697 will be a solution
encukou Apr 27, 2023
e2c4b37
Move declaration to Include/cpython
encukou Apr 27, 2023
ea9e9ac
Style nitpicks
encukou Apr 27, 2023
f9817ca
Clarify the docs a bit
encukou Apr 27, 2023
f0098d6
Convert the test class to a heap type
encukou Apr 28, 2023
cfa59d7
Initialize the memory
encukou Apr 28, 2023
525705a
Doc style fixes
jbradaric Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Style nitpicks
  • Loading branch information
@encukou
encukou committed Apr 27, 2023
commit ea9e9acee1f6eb10c5b798ab883cc0a4b269df39
12 changes: 6 additions & 6 deletions Modules/_testcapimodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3409,8 +3409,9 @@ obj_extra_data_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
{
size_t extra_size = sizeof(PyObject *);
PyObject *obj = PyUnstable_Object_GC_NewWithExtraData(type, extra_size);
if (obj == NULL)
if (obj == NULL) {
return PyErr_NoMemory();
}
memset(obj, '\0', type->tp_basicsize + extra_size);
PyObject_Init(obj, type);
PyObject_GC_Track(obj);
Expand All @@ -3428,10 +3429,10 @@ obj_extra_data_get(PyObject *self, void *Py_UNUSED(ignored))
{
PyObject **extra_storage = obj_extra_data_get_extra_storage(self);
PyObject *value = *extra_storage;
if (!value)
if (!value) {
Py_RETURN_NONE;
Py_INCREF(value);
return value;
}
return Py_NewRef(value);
}

static int
Expand All @@ -3440,8 +3441,7 @@ obj_extra_data_set(PyObject *self, PyObject *newval, void *Py_UNUSED(ignored))
PyObject **extra_storage = obj_extra_data_get_extra_storage(self);
Py_CLEAR(*extra_storage);
if (newval) {
Py_INCREF(newval);
*extra_storage = newval;
*extra_storage = Py_NewRef(newval);
}
return 0;
}
Expand Down