Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. #103927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 5 commits into from
Apr 30, 2023
Merged

gh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. #103927

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
557e6b7
This allows the test runner to execute test_multiprocessing and test_…
zitterbewegung Apr 27, 2023
345d12f
revert whitespace changes
carljm Apr 28, 2023
9b71c20
multiprocessing, not compiler
carljm Apr 28, 2023
19c6c73
This removes an extraneous test package that doesn't exist and also c…
zitterbewegung Apr 29, 2023
b409e2c
simplify logic: no len()s, tight f-expression.
gpshead Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
This removes an extraneous test package that doesn't exist and also c… 
…ode cleanup.

For the new test arguments they were made keyword only and also test_multiprocessing was removed from the SPLITTESTDIRS. The argument splittestdirs was renamed to split_test_dirs for findtests.
  • Loading branch information
@zitterbewegung
zitterbewegung committed Apr 29, 2023
commit 19c6c73959eb9124440fa17eb614cf20d3105fb9
7 changes: 3 additions & 4 deletions Lib/test/libregrtest/runtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ def __str__(self) -> str:

SPLITTESTDIRS = {
"test_asyncio",
"test_multiprocessing",
}

# Storage of uncollectable objects
Expand All @@ -167,7 +166,7 @@ def findtestdir(path=None):
return path or os.path.dirname(os.path.dirname(__file__)) or os.curdir


def findtests(testdir=None, stdtests=STDTESTS, nottests=NOTTESTS, splittestdirs=SPLITTESTDIRS, base_mod=""):
def findtests(testdir=None, stdtests=STDTESTS, nottests=NOTTESTS, *, split_test_dirs=SPLITTESTDIRS, base_mod=""):
"""Return a list of all applicable test modules."""
testdir = findtestdir(testdir)
names = os.listdir(testdir)
Expand All @@ -176,13 +175,13 @@ def findtests(testdir=None, stdtests=STDTESTS, nottests=NOTTESTS, splittestdirs=
for name in names:
mod, ext = os.path.splitext(name)
if mod[:5] == "test_" and mod not in others:
if mod in splittestdirs:
if mod in split_test_dirs:
subdir = os.path.join(testdir, mod)
if len(base_mod):
mod = f"{base_mod}.{mod}"
else:
mod = f"test.{mod}"
tests.extend(findtests(subdir, [], nottests, splittestdirs, mod))
tests.extend(findtests(subdir, [], nottests, split_test_dirs=split_test_dirs, base_mod=mod))
elif ext in (".py", ""):
tests.append(f"{base_mod}.{mod}" if len(base_mod) else mod)
return stdtests + sorted(tests)
Expand Down