[3.11] bpo-35191: Fix unexpected integer truncation in socket.setblocking() #10415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Nov 8, 2018
vstinner
reviewed
Nov 8, 2018
|
It seems like we could further and make the |
|
It was fixed in #15609. |
added 3 commits
December 1, 2023 14:58
On platforms with 64-bit long, socket.setblocking(x) treated all x which lower 32 bits are zero as False due to integer truncation. Reported by ubsan.
72036ce to
cda490b
Compare
|
Rebased on 3.11 which still is not fixed. |
|
@serhiy-storchaka: Maybe you made a mistake, since suddenly, the change started to change 1723 files :-D This PR is for the 3.11 branch. Maybe a new PR for the main branch should be written instead? |
serhiy-storchaka
approved these changes
Dec 1, 2023
vstinner
reviewed
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms with 64-bit long, socket.setblocking(x) treated all x
which lower 32 bits are zero as False due to integer truncation.
Reported by ubsan.
https://bugs.python.org/issue35191