Test join before failing task-done

python · gvanrossum · Apr 6, 2024 · Sep 1, 2022 · Feb 10, 2023 · May 6, 2023
commit 8deca77fd9d12e6f501097d057f31888c170f9b0
@@ -611,18 +611,18 @@ async def test_shutdown_nonempty(self):
         with self.assertRaisesShutdown():
             q.get_nowait()
 
-        # Ensure there is 1 unfinished task
+        # Ensure there is 1 unfinished task, and join() task succeeds
         q.task_done()
-        with self.assertRaises(
-            ValueError, msg="Didn't appear to mark all tasks done"
-        ):
-            q.task_done()
 
-        # Ensure join() task has successfully finished
         await asyncio.sleep(0)
         self.assertTrue(join_task.done())
         await join_task
 
+        with self.assertRaises(
+            ValueError, msg="Didn't appear to mark all tasks done"
+        ):
+            q.task_done()
+
     async def test_shutdown_immediate(self):
         # Test immediately shutting down a queue