Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-103000: Optimise dataclasses.asdict for the common case #104364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 3 commits into from
May 10, 2023
Merged

gh-103000: Optimise dataclasses.asdict for the common case #104364

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4970f5d
Optimise `dataclasses.asdict` for the common case
AlexWaygood May 10, 2023
29231d5
Update 2023-05-10-19-33-36.gh-issue-103000.j0KSfD.rst
AlexWaygood May 10, 2023
4e01d46
this isn't markdown
AlexWaygood May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Optimise dataclasses.asdict for the common case 
Co-authored-by: David Ellis <[email protected]>
  • Loading branch information
@AlexWaygood @DavidCEllis
AlexWaygood and DavidCEllis committed May 10, 2023
commit 4970f5d6590cda345ee286ced85871532aa27846
17 changes: 12 additions & 5 deletions Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,11 +1324,18 @@ def _asdict_inner(obj, dict_factory):
if type(obj) in _ATOMIC_TYPES:
return obj
elif _is_dataclass_instance(obj):
result = []
for f in fields(obj):
value = _asdict_inner(getattr(obj, f.name), dict_factory)
result.append((f.name, value))
return dict_factory(result)
# fast path for the common case
if dict_factory is dict:
return {
f.name: _asdict_inner(getattr(obj, f.name), dict)
for f in fields(obj)
}
else:
result = []
for f in fields(obj):
value = _asdict_inner(getattr(obj, f.name), dict_factory)
result.append((f.name, value))
return dict_factory(result)
elif isinstance(obj, tuple) and hasattr(obj, '_fields'):
# obj is a namedtuple. Recurse into it, but the returned
# object is another namedtuple of the same type. This is
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-05-10-19-33-36.gh-issue-103000.j0KSfD.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve performance of :func:`dataclasses.asdict` for the common case where
`dict_factory` is `dict`.