Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-104050: Add basic typing to CConverter in clinic.py #104538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 2 commits into from
May 16, 2023
Merged

gh-104050: Add basic typing to CConverter in clinic.py #104538

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fa5ea0
gh-104050: Add basic typing to CConverter in clinic.py
erlend-aasland May 16, 2023
6c02f60
Update Tools/clinic/clinic.py
erlend-aasland May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Tools/clinic/clinic.py 
Co-authored-by: Alex Waygood <[email protected]>
  • Loading branch information
@erlend-aasland @AlexWaygood
erlend-aasland and AlexWaygood authored May 16, 2023
commit 6c02f60034b98c3e24080182173a976c12fdaae0
2 changes: 1 addition & 1 deletion Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2776,7 +2776,7 @@ def _render_non_self(self, parameter, data):
if cleanup:
data.cleanup.append('/* Cleanup for ' + name + ' */\n' + cleanup.rstrip() + "\n")

def render(self, parameter: str, data: CRenderData):
def render(self, parameter: str, data: CRenderData) -> None:
Copy link
Copy Markdown
Contributor Author

@erlend-aasland erlend-aasland May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fishy. parameter should be a Parameter instance, but also str is accepted. Let's look into that in a follow-up PR.

"""
parameter is a clinic.Parameter instance.
data is a CRenderData instance.
Expand Down