GH-104668: Don't call PyOS_* hooks in subinterpreters
#104674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should advertise this in What's New as well. |
|
Should we backport it to 3.12? Edit: I noticed that the label isn't added yet. |
|
@brandtbucher this didn't actually end up in the 3.12 branch. Should we backport it, or is it a new feature that should only go into 3.13? |
|
Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2023
…-104674) (cherry picked from commit 357bed0) Co-authored-by: Brandt Bucher <[email protected]>
|
GH-104760 is a backport of this pull request to the 3.12 branch. |
|
I was waiting for the label. 🙂 |
brandtbucher
added a commit
that referenced
this pull request
May 23, 2023
GH-104668: Don't call PyOS_* hooks in subinterpreters (GH-104674) (cherry picked from commit 357bed0) Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyOS_InputHookandPyOS_ReadlineFunctionPointerare now only called in the main interpreter.PyOS_*hooks interact poorly with subinterpreters #104668📚 Documentation preview 📚: https://cpython-previews--104674.org.readthedocs.build/