DOC os.link is not available on Emscripten #104822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Marking as need-backport because Emscripten support was added in 3.11 |
brettcannon
approved these changes
Jul 26, 2023
|
Thanks @rth for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-107308 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2023
…4822) (cherry picked from commit 737d1da) Co-authored-by: Roman Yurchak <[email protected]>
|
GH-107309 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2023
…4822) (cherry picked from commit 737d1da) Co-authored-by: Roman Yurchak <[email protected]>
brettcannon
pushed a commit
that referenced
this pull request
Jul 26, 2023
…04822) (GH-107309) Document that `os.link()` is not available on Emscripten (GH-104822) (cherry picked from commit 737d1da) Co-authored-by: Roman Yurchak <[email protected]>
brettcannon
pushed a commit
that referenced
this pull request
Jul 26, 2023
…04822) (GH-107308) Document that `os.link()` is not available on Emscripten (GH-104822) (cherry picked from commit 737d1da) Co-authored-by: Roman Yurchak <[email protected]>
|
Merged and backported! |
jtcave
pushed a commit
to jtcave/cpython
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small documentation fix to indicate that
os.linkis not available on Emscripten based platforms. This is the case in Pyodide (cf pyodide/pyodide#3880 (comment) for more context) and also the WASM build by Christian Heimes, for instance (https://cheimes.fedorapeople.org/python-wasm/).Change made to be more consistent with other methods of
osmodule that indicate when the Emscripten platform is not supported.📚 Documentation preview 📚: https://cpython-previews--104822.org.readthedocs.build/