Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-104773: PEP 594: Remove the nis module #104897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2023
Merged

gh-104773: PEP 594: Remove the nis module #104897

merged 3 commits into from
May 24, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 24, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
19 tasks
@hugovk
Copy link
Member

hugovk commented May 24, 2023

Some extra nismodule / libnsl bits to remove?

Tools/c-analyzer/cpython/ignored.tsv
285:Modules/nismodule.c  -       TIMEOUT -
286:Modules/nismodule.c  -       aliases -

Tools/c-analyzer/cpython/_parser.py
123:Modules/nismodule.c  /usr/include/tirpc

Tools/c-analyzer/cpython/globals-to-fix.tsv
458:Modules/nismodule.c  nisproc_maplist_2       res     -

PC/pyconfig.h
679:#define HAVE_LIBNSL 1

@vstinner vstinner requested a review from a team as a code owner May 24, 2023 21:31
@vstinner
Copy link
Member Author

Some extra nismodule / libnsl bits to remove?

Well spotted: removed as well.

For now, I prefer to keep this code in configure.ac, since I don't know its purpose and I cannot test a change on Solaris:

$ git grep -B1 -A1 '\<nsl\>'
configure.ac-# Most SVR4 platforms (e.g. Solaris) need -lsocket and -lnsl.
configure.ac:AC_CHECK_LIB(nsl, t_open, [LIBS="-lnsl $LIBS"]) # SVR4
configure.ac-AC_CHECK_LIB(socket, socket, [LIBS="-lsocket $LIBS"], [], $LIBS) # SVR4 sockets

@vstinner vstinner merged commit 17e1fe0 into python:main May 24, 2023
@vstinner vstinner deleted the remove_nis branch May 24, 2023 22:08
@Ahajha Ahajha mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @hugovk @bedevere-bot