Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.11] gh-90005: Don't link with libbsd if not needed (#105236) #105359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023
Merged

[3.11] gh-90005: Don't link with libbsd if not needed (#105236) #105359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[3.11] gh-90005: Don't link with libbsd if not needed (#105236) 
The regression was introduced with commit 5b946ca.
Restore pre gh-29696 behaviour.
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jun 6, 2023
commit a8c9f088d0df2c52baadc9944a16595eb7850c3a
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2023-06-06-09-08-10.gh-issue-90005.8mmeJQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a regression in :file:`configure` where we could end up unintentionally linking with ``libbsd``.
6 changes: 3 additions & 3 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4696,9 +4696,8 @@ AC_CACHE_CHECK([for flock declaration], [ac_cv_flock_decl],
])
dnl Linking with libbsd may be necessary on AIX for flock function.
AS_VAR_IF([ac_cv_flock_decl], [yes],
AC_CHECK_FUNCS([flock])
AC_CHECK_LIB([bsd], [flock], [FCNTL_LIBS="-lbsd"])
)
[AC_CHECK_FUNCS([flock], [],
[AC_CHECK_LIB([bsd], [flock], [FCNTL_LIBS="-lbsd"])])])

PY_CHECK_FUNC([getpagesize], [#include <unistd.h>])

Expand Down