Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-105545: Remove deprecated MacOSXOSAScript._name #105546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 6 commits into from
Jun 9, 2023
Merged

gh-105545: Remove deprecated MacOSXOSAScript._name #105546

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
032d835
gh-105545: Remove deprecated `MacOSXOSAScript._name`
sobolevn Jun 9, 2023
75c6b10
Adds Whats New entry
sobolevn Jun 9, 2023
d27f640
Adds Whats New entry
sobolevn Jun 9, 2023
0aff611
Update Doc/whatsnew/3.13.rst
sobolevn Jun 9, 2023
e402ffe
Proper link
sobolevn Jun 9, 2023
5a23038
Fix CI
sobolevn Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,10 @@ Removed
certificates for you.
(Contributed by Victor Stinner in :gh:`105382`.)

* Remove deprecated ``webbrowser.MacOSXOSAScript._name`` attribute.
Comment thread
hugovk marked this conversation as resolved.
Use ``.name`` attribute instead.
Comment thread
sobolevn marked this conversation as resolved.
Outdated
(Contributed by Nikita Sobolev in :gh:`105546`.)


Porting to Python 3.13
======================
Expand Down
14 changes: 0 additions & 14 deletions Lib/webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,20 +578,6 @@ class MacOSXOSAScript(BaseBrowser):
def __init__(self, name='default'):
super().__init__(name)

@property
def _name(self):
warnings.warn(f'{self.__class__.__name__}._name is deprecated in 3.11'
f' use {self.__class__.__name__}.name instead.',
DeprecationWarning, stacklevel=2)
return self.name

@_name.setter
def _name(self, val):
warnings.warn(f'{self.__class__.__name__}._name is deprecated in 3.11'
f' use {self.__class__.__name__}.name instead.',
DeprecationWarning, stacklevel=2)
self.name = val

def open(self, url, new=0, autoraise=True):
if self.name == 'default':
script = 'open location "%s"' % url.replace('"', '%22') # opens in default browser
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-06-09-08-38-30.gh-issue-105545.2q3ysu.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove deprecated in 3.11 ``webbrowser.MacOSXOSAScript._name`` attribute.