Fixed _get_slots bug, according to issue gh-105866 #105870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
Eclips4
reviewed
Jun 16, 2023
Misc/NEWS.d/next/Library/2023-06-16-19-17-06.gh-issue-105866.0NBveV.rst
Outdated
Show resolved
Hide resolved
|
Also, it would be nice to have tests for this case |
…NBveV.rst Co-authored-by: Kirill Podoprigora <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 19, 2024
…thonGH-105870) (cherry picked from commit a22d05f) Co-authored-by: Aviel Boag <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
|
GH-116978 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 19, 2024
…thonGH-105870) (cherry picked from commit a22d05f) Co-authored-by: Aviel Boag <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
|
GH-116979 is a backport of this pull request to the 3.11 branch. |
ambv
pushed a commit
that referenced
this pull request
Mar 19, 2024
…H-105870) (GH-116978) (cherry picked from commit a22d05f) Co-authored-by: Aviel Boag <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Mar 19, 2024
…H-105870) (GH-116979) (cherry picked from commit a22d05f) Co-authored-by: Aviel Boag <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
…thon#105870) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…thon#105870) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…thon#105870) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed _get_slots bug, according to issue gh-105866
#105866: Fixed _get_slots to account for the implicitly defined slots.