gh-105927: Avoid calling PyWeakref_GET_OBJECT() #105997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vstinner
commented
Jun 22, 2023
•
- Replace PyWeakref_GET_OBJECT() with _PyWeakref_GET_REF().
- _sqlite/blob.c now holds a strong reference to the blob object while calling close_blob().
- _xidregistry_find_type() now holds a strong reference to registered while using it.
- Issue: C API: Add PyWeakref_GetRef() function #105927
* Replace PyWeakref_GET_OBJECT() with _PyWeakref_GET_REF(). * _sqlite/blob.c now holds a strong reference to the blob object while calling close_blob(). * _xidregistry_find_type() now holds a strong reference to registered while using it.
| PyObject *blob = PyWeakref_GetObject(weakref); | ||
| if (!Py_IsNone(blob)) { | ||
| close_blob((pysqlite_Blob *)blob); | ||
| PyObject *blob = _PyWeakref_GET_REF(weakref); |
There was a problem hiding this comment.
Ideally, we should use public API only in the sqlite3 extension module.
There was a problem hiding this comment.
I hesitated to use PyWeakref_GetRef() but pysqlite_close_all_blobs() cannot report errors (return type is void), and I hesitated to use PyErr_WriteUnraisable().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.