[3.7] bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) #10717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix str.format(), float.__format__() and complex.__format__() methods for non-ASCII decimal point when using the "n" formatter. Changes: * Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires a _PyUnicodeWriter object for the buffer and a Python str object for digits. * Rename FILL() macro to unicode_fill(), convert it to static inline function, add "assert(0 <= start);" and rework its code. (cherry picked from commit 59423e3) Co-authored-by: Victor Stinner <[email protected]>
Member
|
The FILL/unicode_fill change is unwanted in 3.7, so I wrote PR #10718 instead. |
Contributor
Author
|
@vstinner: Status check is done, and it's a failure ❌ . |
1 similar comment
Contributor
Author
|
@vstinner: Status check is done, and it's a failure ❌ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix str.format(), float.format() and complex.format() methods
for non-ASCII decimal point when using the "n" formatter.
Changes:
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.
add "assert(0 <= start);" and rework its code.
(cherry picked from commit 59423e3)
Co-authored-by: Victor Stinner [email protected]
https://bugs.python.org/issue33954