gh-104683: Argument Clinic: refactor format_docstring() #107623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract helper methods for formatting the signature and parameter sections, and clean up the remaining function body.
7 tasks
AlexWaygood
reviewed
Aug 4, 2023
Co-authored-by: Alex Waygood <[email protected]>
|
Looks like there's a bug somewhere -- CI is failing |
Yes, splitlines() is not quite the same as the old comprehension :( |
This reverts commit 1d244dc.
|
I reverted the |
AlexWaygood
reviewed
Aug 4, 2023
Co-authored-by: Alex Waygood <[email protected]>
This was referenced Aug 4, 2023
AA-Turner
reviewed
Aug 8, 2023
Co-authored-by: Adam Turner <[email protected]>
AlexWaygood
approved these changes
Aug 8, 2023
AA-Turner
approved these changes
Aug 8, 2023
|
Thanks for the reviews, Adam and Alex! |
|
That's strange; automerge continued through even though the Windows (x86) CI failed (apparently it failed then succeeded because some of the flakey tests were flakey). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract helper methods for formatting the signature and parameter
sections, and clean up the remaining function body.
Tools/clinic/#104683