gh-107710: Speed up logging.getHandlerNames function
#107711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/logging/__init__.py
Outdated
| @@ -916,8 +916,7 @@ def getHandlerNames(): | |||
| """ | |||
| Return all known handler names as an immutable set. | |||
| """ | |||
| result = set(_handlers.keys()) | |||
| return frozenset(result) | |||
| return frozenset(_handlers.keys()) | |||
There was a problem hiding this comment.
I've tested with frozenset(_handlers) it is a bit slower:
(.venv) ~/Desktop/cpython issue-107710 ✗ 1 ⚠️
» pyperf timeit --setup 'import ex; l = ex.logging' 'l.getHandlerNames()'
.....................
Mean +- std dev: 2.07 us +- 0.02 us
(.venv) ~/Desktop/cpython issue-107710 ✗
» pyperf timeit --setup 'import ex; l = ex.logging' 'l.getHandlerNames()'
.....................
Mean +- std dev: 2.07 us +- 0.01 us
(.venv) ~/Desktop/cpython issue-107710 ✗
» pyperf timeit --setup 'import ex; l = ex.logging' 'l.getHandlerNames()'
.....................
Mean +- std dev: 2.07 us +- 0.01 us
There was a problem hiding this comment.
I don't think a 3us difference is a good enough reason to avoid using the simpler code here. And it is still faster than main :)
There was a problem hiding this comment.
The difference is so small that I would classify this change as a code cleanup rather than an optimization.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lizzydavis695
approved these changes
Aug 7, 2023
AlexWaygood
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging.getHandlerNames()#107710