Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-93057: Deprecate positional use of optional sqlite3.connect() params #107948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 8 commits into from
Aug 15, 2023
Merged

gh-93057: Deprecate positional use of optional sqlite3.connect() params #107948

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
40996ef
gh-93057: Deprecate positional use of optional sqlite3.connect() params
erlend-aasland Aug 14, 2023
b84ee0e
Fix test and news entries
erlend-aasland Aug 14, 2023
6ab04fd
regen clinic
erlend-aasland Aug 14, 2023
01c4067
Address review: don't repeat the what's new entry
erlend-aasland Aug 14, 2023
de7e87c
Manually insert deprecation warning for sqlite3.connect
erlend-aasland Aug 15, 2023
6f3e5c6
Pull in main
erlend-aasland Aug 15, 2023
4018bd9
Also test module level connect()
erlend-aasland Aug 15, 2023
1f48783
Also mention the Connection constructor in What's New/NEWS
erlend-aasland Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test and news entries
  • Loading branch information
@erlend-aasland
erlend-aasland committed Aug 14, 2023
commit b84ee0e3603d1ed56dc7f8fd2b418b184579a6ca
9 changes: 2 additions & 7 deletions Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,7 @@ sqlite3
-------

* Passing more than one positional argument to :func:`sqlite3.connect` is
deprecated. Parameters *timeout*, *detect_types*, *isolation_level*,
*check_same_thread*, *factory*, *cached_statements*, and *uri* is deprecated.
They will become keyword-only parameters in Python 3.15.
deprecated. The remaining parameters will become keyword-only in Python 3.15.
(Contributed by Erlend E. Aasland :gh:`93057`.)

traceback
Expand Down Expand Up @@ -229,10 +227,7 @@ Deprecated
(Contributed by Victor Stinner in :gh:`105096`.)

* Passing more than one positional argument to :func:`sqlite3.connect` is
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
deprecated. Parameters *timeout*, *detect_types*, *isolation_level*,
*check_same_thread*, *factory*, *cached_statements*, and *uri* is deprecated.
They will become keyword-only parameters in Python 3.15.
(Contributed by Erlend E. Aasland :gh:`93057`.)
deprecated. The remaining parameters will become keyword-only in Python 3.15.

Pending Removal in Python 3.14
------------------------------
Expand Down
10 changes: 9 additions & 1 deletion Lib/test/test_sqlite3/test_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,15 @@ class Factory(sqlite.Connection):
def __init__(self, *args, **kwargs):
super(Factory, self).__init__(*args, **kwargs)

con = sqlite.connect(":memory:", 5.0, 0, None, True, Factory)
regex = (
r"Passing more than 1 positional argument to _sqlite3.Connection\(\) "
Comment thread
erlend-aasland marked this conversation as resolved.
r"is deprecated. Parameters 'timeout', 'detect_types', "
r"'isolation_level', 'check_same_thread', 'factory', "
r"'cached_statements' and 'uri' will become keyword-only "
r"parameters in Python 3.15."
)
with self.assertWarnsRegex(DeprecationWarning, regex):
con = sqlite.connect(":memory:", 5.0, 0, None, True, Factory)
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
self.assertIsNone(con.isolation_level)
self.assertIsInstance(con, Factory)

Expand Down
6 changes: 2 additions & 4 deletions Misc/NEWS.d/next/Library/2023-08-14-19-49-02.gh-issue-93057.5nJwO5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
Passing more than one positional argument to :func:`sqlite3.connect` is
deprecated. Parameters *timeout*, *detect_types*, *isolation_level*,
*check_same_thread*, *factory*, *cached_statements*, and *uri* is
deprecated. They will become keyword-only parameters in Python 3.15. Patch
by Erlend E. Aasland.
deprecated. The remaining parameters will become keyword-only in Python 3.15.
Patch by Erlend E. Aasland.