[3.10] Fix inspect.signature call on mocks (#96335) (gh-96127)
#108652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR! Unfortunately, Python 3.10 is now quite an old version of Python, that's only accepting security fixes. This isn't a security fix, as far as I can tell. I'm therefore closing this, but thanks again for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting this fix to make inspect.signature() work with AsyncMock().
This was previously considered in #101647, but that required more rework. The change looked pretty straightforward, and tests passed locally, so putting this up.
Followed process at https://devguide.python.org/#quick-reference to create PR