gh-82367: Use FindFirstFile Win32 API in ntpath.realpath()
#110298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zware
reviewed
Oct 3, 2023
Misc/NEWS.d/next/Windows/2023-10-03-12-30-59.gh-issue-82367.nxwfMx.rst
Outdated
Show resolved
Hide resolved
|
The code change looks great to me. Awesome job! With Zach's requested doc changes, I think this is good to merge. |
2c49ffc to
4590347
Compare
moonsikpark
added a commit
to moonsikpark/cpython
that referenced
this pull request
Oct 4, 2023
…ython#110298) * Use `FindFirstFile` Win32 API to fix a bug where `ntpath.realpath()` breaks out of traversing a series of paths where a (handled) `ERROR_ACCESS_DENIED` or `ERROR_SHARING_VIOLATION` occurs. * Update docs to reflect that `ntpath.realpath()` eliminates MS-DOS style names.
4590347 to
f675a4f
Compare
|
All commit authors signed the Contributor License Agreement. |
moonsikpark
added a commit
to moonsikpark/cpython
that referenced
this pull request
Oct 4, 2023
…ython#110298) * Use `FindFirstFile` Win32 API to fix a bug where `ntpath.realpath()` breaks out of traversing a series of paths where a (handled) `ERROR_ACCESS_DENIED` or `ERROR_SHARING_VIOLATION` occurs. * Update docs to reflect that `ntpath.realpath()` eliminates MS-DOS style names.
d88c757 to
e17852c
Compare
eryksun
reviewed
Oct 4, 2023
eryksun
reviewed
Oct 5, 2023
eryksun
reviewed
Oct 5, 2023
eryksun
reviewed
Oct 5, 2023
eryksun
reviewed
Oct 5, 2023
eryksun
reviewed
Oct 5, 2023
eryksun
reviewed
Oct 5, 2023
eryksun
approved these changes
Oct 5, 2023
…ython#110298) * Use `FindFirstFile` Win32 API to fix a bug where `ntpath.realpath()` breaks out of traversing a series of paths where a (handled) `ERROR_ACCESS_DENIED` or `ERROR_SHARING_VIOLATION` occurs. * Update docs to reflect that `ntpath.realpath()` eliminates MS-DOS style names.
1766bc3 to
2b5a29e
Compare
|
Thanks Steve and Eryk for the reviews, and Moonsik for the patch and excellent collaboration! |
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ythonGH-110298) * Use `FindFirstFile` Win32 API to fix a bug where `ntpath.realpath()` breaks out of traversing a series of paths where a (handled) `ERROR_ACCESS_DENIED` or `ERROR_SHARING_VIOLATION` occurs. * Update docs to reflect that `ntpath.realpath()` eliminates MS-DOS style names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ntpath.realpath()breaks out of traversing a series of paths where a (handled) ERROR_ACCESS_DENIED or ERROR_SHARING_VIOLATION occurs.Using
FindFirstFileWin32 API, we can query their real name to correct the case and also resolve MS-DOS (also called 8.3) style file names such asC:\\LONGFI~1.TXT.📚 Documentation preview 📚: https://cpython-previews--110298.org.readthedocs.build/