Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic #110603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic #110603

merged 1 commit into from
Oct 10, 2023
+20 −5

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Oct 10, 2023 •
edited by bedevere-app bot
Loading

These are more opinionated, lint-style checks than the existing pyflakes rules that we currently have enabled on Argument Clinic, following #110559. The full list of pyupgrade rules is at https://docs.astral.sh/ruff/rules/#pyupgrade-up.

Thoughts? Is this a useful addition?

@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Oct 10, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2023
Closed
@AlexWaygood
Copy link
Member Author

Thanks, both! I chatted with @hugovk at the sprint (you're missed @erlend-aasland 😢), and I think there probably aren't any other rules that are worth enabling right now (but feel free to propose any more that that you think would be useful!)

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 10, 2023 09:14
@erlend-aasland
Copy link
Contributor

Thanks, both! I chatted with @hugovk at the sprint (you're missed @erlend-aasland 😢), and I think there probably aren't any other rules that are worth enabling right now (but feel free to propose any more that that you think would be useful!)

For these DevOps things, I fully trust you two! :) It is very nice that we're getting more automated machinery in place in the CPython repo; I love it! I wish I was in Brno with y'all; it is a very nice city IMO.

@AlexWaygood AlexWaygood merged commit fc811c8 into python:main Oct 10, 2023
@AlexWaygood AlexWaygood deleted the ruff-pyupgrade-argclinic branch October 10, 2023 09:35
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2023

GH-110609 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
@AlexWaygood @miss-islington
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
50c3fd6 
…nt Clinic (pythonGH-110603)

(cherry picked from commit fc811c8)

Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood added a commit that referenced this pull request Oct 10, 2023
@miss-islington @AlexWaygood
[3.12] gh-110558: Enable ruff's pyupgrade rules when running on Argum…
55d6076 
…ent Clinic (GH-110603) (#110609)

gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic (GH-110603)
(cherry picked from commit fc811c8)

Co-authored-by: Alex Waygood <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
eccbdfe 
…nt Clinic (python#110603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexWaygood @erlend-aasland @miss-islington @hugovk