Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-107450: Fix testMemoryErrorBigSource in test_exceptions #110871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-107450: Fix testMemoryErrorBigSource in test_exceptions #110871

wants to merge 1 commit into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 14, 2023 •
edited by bedevere-app bot
Loading

  1. It uses 4GB of memory, not 3GB.
  2. It should be skipped if not enough memory
  3. Scope is too wide: the error may occur not only at compile time, but may also occur when the source line is generated or when the compiled code is executed.

@bedevere-app bedevere-app bot mentioned this pull request Oct 14, 2023
Closed
2 tasks
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Oct 14, 2023
@serhiy-storchaka
Copy link
Member Author

This PR also slightly optimizes the test: now it is 7 seconds faster on my computer (23 seconds instead of 30 seconds).

@lysnikolaou
Copy link
Member

@serhiy-storchaka I've opened #110832 that fixes the test. Maybe push the optimization to that branch?

@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 14, 2023
Merged
@serhiy-storchaka
Copy link
Member Author

Included in #110832.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees
No one assigned
Labels
awaiting core review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @lysnikolaou