Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-111159: Fix SyntaxError doctests for non-builtin exception classes #111541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 6 commits into from
Nov 4, 2023
Merged

gh-111159: Fix SyntaxError doctests for non-builtin exception classes #111541

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fa1722
gh-111159: Fix `SyntaxError` doctests for non-builtin exception classes
sobolevn Oct 31, 2023
42e2887
Address review
sobolevn Oct 31, 2023
7d388e2
Apply suggestions from code review
sobolevn Oct 31, 2023
1c03d66
Apply suggestions from code review
sobolevn Nov 1, 2023
84177b2
Add news
sobolevn Nov 4, 2023
e545306
Update 2023-11-04-10-24-25.gh-issue-111541.x0RBI1.rst
sobolevn Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Oct 31, 2023
commit 42e2887514d26d150a722f0a4c126764c4dd63f9
9 changes: 3 additions & 6 deletions Lib/doctest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,15 +1399,12 @@ def __run(self, test, compileflags, out):
# we don't care about the carets / suggestions / etc
# We only care about the error message and notes.
# They start with `SyntaxError:` (or any other class name)
exc_name = f"{exception[0].__qualname__}:"
exc_fullname = f"{exception[0].__module__}.{exception[0].__qualname__}:"
Comment thread
sobolevn marked this conversation as resolved.
Outdated
exc_msg_index = next(
index
for index, line in enumerate(formatted_ex)
if (
line.startswith(f"{exception[0].__qualname__}:")
or line.startswith(
f"{exception[0].__module__}.{exception[0].__qualname__}:",
)
)
if line.startswith(exc_name) or line.startswith(exc_fullname)
Comment thread
sobolevn marked this conversation as resolved.
Outdated
)
formatted_ex = formatted_ex[exc_msg_index:]

Expand Down