Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-99367: Do not mangle sys.path[0] in pdb if safe_path is set #111762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 7 commits into from
Nov 27, 2023
Merged

gh-99367: Do not mangle sys.path[0] in pdb if safe_path is set #111762

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3fe225d
Do not mangle sys.path[0] if safe_path is set
gaogaotiantian Nov 5, 2023
1ec6724
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 5, 2023
9a8919e
Rephrase the comments and simplified the logic
gaogaotiantian Nov 6, 2023
c5fabe6
Update Lib/pdb.py
gaogaotiantian Nov 6, 2023
d73c2da
Add whatsnew entry
gaogaotiantian Nov 27, 2023
c810afc
Update Doc/whatsnew/3.13.rst
gaogaotiantian Nov 27, 2023
d40d3db
Update phrasing
gaogaotiantian Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rephrase the comments and simplified the logic
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Nov 6, 2023
commit 9a8919eed3012f7e9d73846c6e530e065dad6b9d
6 changes: 3 additions & 3 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ def check(self):
print('Error:', self.orig, 'is a directory')
sys.exit(1)

# Replace pdb's dir with script's dir in front of module search path
# if safe_path is not set, otherwise sys.path[0] is not pdb's dir
if not getattr(sys.flags, 'safe_path', None):
# If safe_path(-P) is not set, sys.path[0] would be the directory
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# If safe_path(-P) is not set, sys.path[0] would be the directory
# If safe_path (-P) is not selected, sys.path[0] would be the directory

Comment thread
gaogaotiantian marked this conversation as resolved.
Outdated
# of pdb, and we should replace it with the directory of the script
if not sys.flags.safe_path:
sys.path[0] = os.path.dirname(self)

@property
Expand Down