Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-107149: make new opcode util functions private rather than public and unstable #112042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2023
Merged

gh-107149: make new opcode util functions private rather than public and unstable #112042

merged 6 commits into from
Nov 14, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 13, 2023 •
edited by bedevere-app bot
Loading

@iritkatriel iritkatriel added interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API labels Nov 13, 2023
@iritkatriel iritkatriel requested a review from vstinner November 13, 2023 15:52
@bedevere-app bedevere-app bot mentioned this pull request Nov 13, 2023
Closed
vstinner
vstinner reviewed Nov 13, 2023
View reviewed changes
@vstinner
Copy link
Member

vstinner added the skip news label Nov 13, 2023

Since functions are new in Python 3.13, there is no need to document these changes.

arhadthedev
arhadthedev reviewed Nov 13, 2023
View reviewed changes
iritkatriel
iritkatriel commented Nov 13, 2023
View reviewed changes
vstinner
vstinner approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for moving definitions to pycore_compile.h.

@iritkatriel iritkatriel enabled auto-merge (squash) November 14, 2023 00:09
@iritkatriel iritkatriel merged commit 36aab34 into python:main Nov 14, 2023
@vstinner
Copy link
Member

Thanks @iritkatriel. It's better to keep the API private for now, and only consider making it public if we have a clear user request to make it public (even if it's as an "unstable" API).

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-107149: make new opcode util functions private rather than p…
0e1c4df 
…ublic and unstable (python#112042)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-107149: make new opcode util functions private rather than p…
ce1ed61 
…ublic and unstable (python#112042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@vstinner vstinner vstinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news topic-C-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @vstinner @arhadthedev