GH-111784: Fix segfault by keeping pyexpat module alive for capsule lifetime #112104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this patch I still getting segmentation fault: ./python.exe scratch.py
/Users/admin/Library/Application Support/JetBrains/CLion2023.2/scratches/scratch.py:12: DeprecationWarning: There is no current event loop
asyncio.ensure_future(self._end_stream_wait())
zsh: segmentation fault ./python.exe |
|
Looks good to me. @Eclips4, did you do a clean build before testing this? ( |
Yes. |
|
I'm seeing the same segfault too, with my original reproducer. (I've applied this change on top of 3.12.0) |
My week's research says that there's two possible segfaults. Soon I'll try to summarize what's actually happening. |
|
Closing it due to merge of #113405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the segfault reported on the issue, it also avoids adding any new API as it has to be backported and is minimal.
_elementtree.XMLParser#111784