-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-112194: Convert more examples to doctests in typing.py
#112195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall I like this. In general I like doctests to look pretty much like actual REPL sessions, though: here that mostly means fewer blank lines
Co-authored-by: Alex Waygood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…thonGH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
…thonGH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
GH-112208 is a backport of this pull request to the 3.12 branch. |
GH-112209 is a backport of this pull request to the 3.11 branch. |
…H-112195) (#112209) gh-112194: Convert more examples to doctests in `typing.py` (GH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
…H-112195) (#112208) gh-112194: Convert more examples to doctests in `typing.py` (GH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
…thon#112195) Co-authored-by: Alex Waygood <[email protected]>
…thon#112195) Co-authored-by: Alex Waygood <[email protected]>
typing
module #112194