Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-112316: Improve docs of inspect.signature and Signature.from_callable #112317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2023
Merged

gh-112316: Improve docs of inspect.signature and Signature.from_callable #112317

merged 3 commits into from
Dec 2, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 22, 2023 •
edited by github-actions bot
Loading

@sobolevn sobolevn added skip news needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 22, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 22, 2023
Closed
@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Nov 22, 2023
@AlexWaygood AlexWaygood removed the needs backport to 3.10 only security fixes label Nov 22, 2023
AlexWaygood
AlexWaygood requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bedevere-app
Copy link

bedevere-app bot commented Nov 29, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

AlexWaygood
AlexWaygood reviewed Dec 2, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are other methods in this class that also have not-ideal docs markup (using `` for parameters, etc.). Would you be willing to do a followup PR for those, to make the whole class consistent in its markup?

@AlexWaygood AlexWaygood enabled auto-merge (squash) December 2, 2023 13:12
@AlexWaygood AlexWaygood merged commit a74daba into python:main Dec 2, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a74daba7ca8b68f47284d82d4604721b8748bbde 3.12

@miss-islington-app
Copy link

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a74daba7ca8b68f47284d82d4604721b8748bbde 3.11

@AlexWaygood AlexWaygood assigned sobolevn and unassigned AlexWaygood Dec 2, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 2, 2023
@sobolevn @AlexWaygood
pythongh-112316: Improve docs of inspect.signature and `Signature.f…
deea6fd 
…rom_callable` (python#112317)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2023

GH-112629 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 2, 2023
AlexWaygood added a commit that referenced this pull request Dec 2, 2023
@AlexWaygood @sobolevn
[3.12] gh-112316: Improve docs of inspect.signature and `Signature.…
e3c7947 
…from_callable` (#112317) (#112629)

gh-112316: Improve docs of `inspect.signature` and `Signature.from_callable` (#112317)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2023

GH-112630 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 2, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 2, 2023
@sobolevn @AlexWaygood
[3.11] pythongh-112316: Improve docs of inspect.signature and `Sign…
040fd39 
…ature.from_callable` (python#112317)

(cherry-picked from commit a74daba)

Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood added a commit that referenced this pull request Dec 2, 2023
@AlexWaygood @sobolevn
[3.11] gh-112316: Improve docs of inspect.signature and `Signature.…
8d8efe7 
…from_callable` (#112317) (#112630)

(cherry-picked from commit a74daba)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @AlexWaygood @aisk
pythongh-112316: Improve docs of inspect.signature and `Signature.f…
150d8f6 
…rom_callable` (python#112317)

Co-authored-by: Alex Waygood <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @AlexWaygood @Glyphack
pythongh-112316: Improve docs of inspect.signature and `Signature.f…
1df58f3 
…rom_callable` (python#112317)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @hugovk @AlexWaygood