Thanks to visit codestin.com
Credit goes to github.com

gh-112618: Make `Annotated` cache typed #112619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AlexWaygood merged 9 commits into python:main from sobolevn:issue-112618

Dec 2, 2023

Member

sobolevn commented Dec 2, 2023 •

edited by bedevere-app bot

Loading

Issue: typing.get_type_hints Can Return Incorrect Type for Annotated Metadata #112618


          pythongh-112618: Make Annotated cache typed

bcb274c

sobolevn requested review from JelleZijlstra and AlexWaygood as code owners

December 2, 2023 09:58

bedevere-app bot added the awaiting review label

bedevere-app bot mentioned this pull request

typing.get_type_hints Can Return Incorrect Type for Annotated Metadata #112618

Closed


          Update 2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst

3b57302

sobolevn commented

View reviewed changes

Lib/typing.py Outdated Show resolved Hide resolved

AlexWaygood reviewed

View reviewed changes

Lib/test/test_typing.py Outdated Show resolved Hide resolved

AlexWaygood added topic-typing needs backport to 3.11 needs backport to 3.12 labels

AlexWaygood reviewed

View reviewed changes

Misc/NEWS.d/next/Library/2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst Outdated Show resolved Hide resolved

AlexWaygood reviewed

View reviewed changes

Member

AlexWaygood left a comment

Thanks, nice fix!

sobolevn and others added 3 commits

December 2, 2023 15:58


          Update Misc/NEWS.d/next/Library/2023-12-02-12-55-17.gh-issue-112618.7…

70895b4

…_FT8-.rst

Co-authored-by: Alex Waygood <[email protected]>


          Rename type

03b43b3


          Address review

b9a0c33

AlexWaygood reviewed

View reviewed changes

Lib/test/test_typing.py Outdated Show resolved Hide resolved


          Address review

13eb192

AlexWaygood reviewed

View reviewed changes

Misc/NEWS.d/next/Library/2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst Outdated Show resolved Hide resolved


          Update 2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst

0a842a0

AlexWaygood reviewed

View reviewed changes

Lib/test/test_typing.py Outdated Show resolved Hide resolved

Lib/test/test_typing.py Outdated Show resolved Hide resolved

sobolevn and others added 2 commits

December 2, 2023 17:48


          Apply suggestions from code review

b83154b

Co-authored-by: Alex Waygood <[email protected]>


          fix syntaxerror

5025f1c

AlexWaygood approved these changes

View reviewed changes

Member

AlexWaygood left a comment

Thanks, LGTM! Will hold off merging for a bit in case @JelleZijlstra has any objections, though :)

bedevere-app bot added awaiting merge and removed awaiting review labels

JelleZijlstra approved these changes

View reviewed changes

AlexWaygood merged commit a35a305 into python:main

miss-islington-app bot commented Dec 2, 2023

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-app bot removed the awaiting merge label

miss-islington-app bot commented Dec 2, 2023

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a35a30509820f956d6feeaa0dbf42e9ca82c12bb 3.12

miss-islington-app bot assigned AlexWaygood

miss-islington-app bot commented Dec 2, 2023

Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a35a30509820f956d6feeaa0dbf42e9ca82c12bb 3.11

AlexWaygood mentioned this pull request

[3.12] gh-112618: Make Annotated cache typed (#112619) #112628

Merged

bedevere-app bot commented Dec 2, 2023

GH-112628 is a backport of this pull request to the 3.12 branch.

bedevere-app bot removed the needs backport to 3.12 label

AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request


          [3.12] pythongh-112618: Make Annotated cache typed (python#112619)

f5c1a10

AlexWaygood removed the needs backport to 3.11 label

Member

AlexWaygood commented Dec 2, 2023 •

edited

Loading

I've removed the "needs backport to 3.11" label from this PR, since it'll be easier to backport #112628 (which is the 3.12 backport) to 3.11 after that one's merged.

AlexWaygood added a commit that referenced this pull request


          [3.12] gh-112618: Make Annotated cache typed (#112619) (#112628)

2a378ca

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request


          [3.12] pythongh-112618: Make Annotated cache typed (pythonGH-112619) (p…

229e18d

…ythonGH-112628)

(cherry picked from commit 2a378ca)

Co-authored-by: Alex Waygood <[email protected]>

AlexWaygood added a commit that referenced this pull request


          [3.11] [3.12] gh-112618: Make Annotated cache typed (GH-112619) (GH-1…

db53770

…12628) (#112633)

[3.12] gh-112618: Make Annotated cache typed (GH-112619) (GH-112628)
(cherry picked from commit 2a378ca)

Co-authored-by: Alex Waygood <[email protected]>

aisk pushed a commit to aisk/cpython that referenced this pull request


          pythongh-112618: Make Annotated cache typed (python#112619)

ca2e49c

Co-authored-by: Alex Waygood <[email protected]>

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request


          pythongh-112618: Make Annotated cache typed (python#112619)

aae749f

Co-authored-by: Alex Waygood <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels