gh-112620: Fix dis error on show_cache with labels #112621
Conversation
There was a problem hiding this comment.
Wouldn't it be simpler to add an optional label_width keyword arg to Instruction? Or is that signature unchangeable? The root cause seems to be that Instruction has a label_width attribute that's not set by the constructor but by some code called immediately after the constructor -- but this is done only for regular instructions, not for the ("fake"?) instructions used to render cache entries. (Ditto for exc_handler.)
I understand that for backwards compatibility we can't make these two fields slots in _Instruction -- but we could still set them in Instruction.__init__()? (We'd have to add that method.)
|
I could do that, but ultimately my plan is to separate instruction generation from formatting, and then the label width is not a property of the instruction. |
Cache entries take the label_width from the instruction that precedes them.
The dis module needs to be refactored to separate Instruction generation from formatting, then this will be simpler.
Fixes #112620.