Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-112278: reduce time cost for platform module when no permission to WMI on Windows #112658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 6 commits into from
Dec 7, 2023
Merged

gh-112278: reduce time cost for platform module when no permission to WMI on Windows #112658

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d24810
using an event object to simulate timeout for _wmi.exec_query
aisk Dec 3, 2023
d1630d1
change the _wmi_query implementation to dummy if it failed first time
aisk Dec 3, 2023
497b14a
Update PC/_wmimodule.cpp
aisk Dec 5, 2023
f1ee797
refactor _wmi_query to handle unsupport condition
aisk Dec 5, 2023
2a1ac5a
fix global _wmi declaration
aisk Dec 5, 2023
da0ddb1
handle SetEvent error
aisk Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update PC/_wmimodule.cpp 
Co-authored-by: Steve Dower <[email protected]>
  • Loading branch information
@aisk @zooba
aisk and zooba authored Dec 5, 2023
commit 497b14a6e627c445fdec1921d0878c0a3a764d16
8 changes: 4 additions & 4 deletions PC/_wmimodule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,10 @@ _wmi_exec_query_impl(PyObject *module, PyObject *query)
}
}

// If current user doesn't have permission to query the WMI, the function
// IWbemLocator::ConnectServer will hang for 5 seconds, and there is no way
// to specify the timeout. So we use an Event object to simulate a timeout.
// More detail: gh-112278.
// gh-112278: If current user doesn't have permission to query the WMI, the
// function IWbemLocator::ConnectServer will hang for 5 seconds, and there
// is no way to specify the timeout. So we use an Event object to simulate
// a timeout.
switch (WaitForSingleObject(data.connectEvent, 100)) {
case WAIT_OBJECT_0:
break;
Expand Down