Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows #113049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 14 commits into from
Dec 14, 2023
Merged

gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows #113049

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0d117a1
gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on W…
serhiy-storchaka Dec 13, 2023
a69e8cc
Fix tests on Windows.
serhiy-storchaka Dec 13, 2023
167c00d
Fix clinic.
serhiy-storchaka Dec 13, 2023
ac3ed22
Fix clinic and Windows again.
serhiy-storchaka Dec 13, 2023
62a69c9
Update docs.
serhiy-storchaka Dec 13, 2023
aebcd68
Run all tests.
serhiy-storchaka Dec 13, 2023
1f47f6a
What's New.
serhiy-storchaka Dec 13, 2023
3f3e25a
Revert auditing changes.
serhiy-storchaka Dec 13, 2023
5f5f826
Fix test_shutil on Windows.
serhiy-storchaka Dec 13, 2023
64883ac
Lie to Sphinx.
serhiy-storchaka Dec 13, 2023
37725be
Apply suggestions from code review
serhiy-storchaka Dec 14, 2023
b1b2914
Merge branch 'main' into win-chmod-follow-symlinks
serhiy-storchaka Dec 14, 2023
fbf0f88
Merge branch 'main' into win-chmod-follow-symlinks
serhiy-storchaka Dec 14, 2023
17b0faf
Add more warnings about the default value.
serhiy-storchaka Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests on Windows.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Dec 13, 2023
commit a69e8cc7e44fdb048e58cb574ccf5fad1f6761ec
30 changes: 18 additions & 12 deletions Lib/test/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,16 +940,18 @@ def test_utime(self):
def check_chmod(self, chmod_func, target, **kwargs):
mode = os.stat(target).st_mode
try:
chmod_func(target, mode & ~stat.S_IWRITE, **kwargs)
self.assertEqual(os.stat(target).st_mode, mode & ~stat.S_IWRITE)
new_mode = mode & ~(stat.S_IWOTH | stat.S_IWGRP | stat.S_IWUSR)
chmod_func(target, new_mode, **kwargs)
self.assertEqual(os.stat(target).st_mode, new_mode)
if stat.S_ISREG(mode):
try:
with open(target, 'wb+'):
pass
except PermissionError:
pass
chmod_func(target, mode | stat.S_IWRITE, **kwargs)
self.assertEqual(os.stat(target).st_mode, mode | stat.S_IWRITE)
new_mode = mode | (stat.S_IWOTH | stat.S_IWGRP | stat.S_IWUSR)
chmod_func(target, new_mode, **kwargs)
self.assertEqual(os.stat(target).st_mode, new_mode)
if stat.S_ISREG(mode):
with open(target, 'wb+'):
pass
Expand Down Expand Up @@ -984,24 +986,28 @@ def check_chmod_link(self, chmod_func, target, link, **kwargs):
target_mode = os.stat(target).st_mode
link_mode = os.lstat(link).st_mode
try:
chmod_func(link, target_mode & ~stat.S_IWRITE, **kwargs)
self.assertEqual(os.stat(target).st_mode, target_mode & ~stat.S_IWRITE)
new_mode = target_mode & ~(stat.S_IWOTH | stat.S_IWGRP | stat.S_IWUSR)
chmod_func(link, new_mode, **kwargs)
self.assertEqual(os.stat(target).st_mode, new_mode)
self.assertEqual(os.lstat(link).st_mode, link_mode)
chmod_func(link, target_mode | stat.S_IWRITE)
self.assertEqual(os.stat(target).st_mode, target_mode | stat.S_IWRITE)
new_mode = target_mode | (stat.S_IWOTH | stat.S_IWGRP | stat.S_IWUSR)
chmod_func(link, new_mode, **kwargs)
self.assertEqual(os.stat(target).st_mode, new_mode)
self.assertEqual(os.lstat(link).st_mode, link_mode)
finally:
posix.chmod(target, target_mode)

def check_lchmod_link(self, chmod_func, target, link, **kwargs):
target_mode = os.stat(target).st_mode
link_mode = os.lstat(link).st_mode
chmod_func(link, link_mode & ~stat.S_IWRITE, **kwargs)
new_mode = link_mode & ~(stat.S_IWOTH | stat.S_IWGRP | stat.S_IWUSR)
chmod_func(link, new_mode, **kwargs)
self.assertEqual(os.stat(target).st_mode, target_mode)
self.assertEqual(os.lstat(link).st_mode, link_mode & ~stat.S_IWRITE)
chmod_func(link, link_mode | stat.S_IWRITE)
self.assertEqual(os.lstat(link).st_mode, new_mode)
new_mode = link_mode | (stat.S_IWOTH | stat.S_IWGRP | stat.S_IWUSR)
chmod_func(link, new_mode, **kwargs)
self.assertEqual(os.stat(target).st_mode, target_mode)
self.assertEqual(os.lstat(link).st_mode, link_mode | stat.S_IWRITE)
self.assertEqual(os.lstat(link).st_mode, new_mode)

@os_helper.skip_unless_symlink
def test_chmod_file_symlink(self):
Expand Down
2 changes: 1 addition & 1 deletion Modules/clinic/posixmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.