Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-113421: Fix multiprocessing logger #113423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 8 commits into from
Dec 24, 2023
Merged

GH-113421: Fix multiprocessing logger #113423

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
772a742
Fix multiprocessing logger
xu-song Dec 23, 2023
0c71144
add news entry
xu-song Dec 23, 2023
493414b
Add format unittest for multiprocessing logger
xu-song Dec 23, 2023
5313957
Initialize handler with io.StringIO()
xu-song Dec 23, 2023
f42181a
Add assert; Remove handler after test
xu-song Dec 24, 2023
9705a0b
Add try finnaly block; Restore logger level
xu-song Dec 24, 2023
04509a7
remove unused import
xu-song Dec 24, 2023
a49b399
Simplify unittest
xu-song Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add assert; Remove handler after test
  • Loading branch information
@xu-song
xu-song committed Dec 24, 2023
commit f42181a3e73266550538023e550021f90a05be62
27 changes: 23 additions & 4 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import sys
import os
import gc
import re
import errno
import functools
import signal
Expand Down Expand Up @@ -4724,17 +4725,35 @@ def test_level(self):
root_logger.setLevel(root_level)
logger.setLevel(level=LOG_LEVEL)

def test_format(self):
def assert_log_lines(self, expected_values, stream=None):
stream = stream or self.stream
actual_lines = stream.getvalue().splitlines()
self.assertEqual(len(actual_lines), len(expected_values))
for actual, expected in zip(actual_lines, expected_values):
self.assertEqual(actual, expected)
s = stream.read()
if s:
self.fail("Remaining output at end of log stream:\n" + s)

def test_filename(self):
logger = multiprocessing.get_logger()
logger.setLevel(util.DEBUG)
handler = logging.StreamHandler(io.StringIO())
logging_format = '[%(levelname)s] [%(processName)s] [%(filename)s:%(lineno)d:%(funcName)s] %(message)s'
stream = io.StringIO()
handler = logging.StreamHandler(stream)
logging_format = '[%(levelname)s] [%(filename)s] %(message)s'
handler.setFormatter(logging.Formatter(logging_format))
logger.addHandler(handler)
logger.info('print info')
util.info('print info again')
logger.debug('print debug')
pool_in_process()
self.assert_log_lines([
'[INFO] [_test_multiprocessing.py] print info',
'[INFO] [_test_multiprocessing.py] print info again',
'[DEBUG] [_test_multiprocessing.py] print debug',
], stream)
logger.setLevel(LOG_LEVEL)
logger.removeHandler(handler)
handler.close()


# class _TestLoggingProcessName(BaseTestCase):
Expand Down