-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
GH-105900: Fix pathlib.Path.symlink_to(target_is_directory=...)
docs
#114035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…)` docs Clarify that *target_is_directory* only matters if the target doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On reading this, I was confused by the word 'type', and it took me a second to realise this was file/directory. I've proposed an alternative wording that avoids this, but if I'm overblowing the issue then the current wording seems good.
A
Thanks Adam :) |
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…)` docs (pythonGH-114035) Clarify that *target_is_directory* only matters if the target doesn't exist. (cherry picked from commit b822b85) Co-authored-by: Barney Gale <[email protected]>
…)` docs (pythonGH-114035) Clarify that *target_is_directory* only matters if the target doesn't exist. (cherry picked from commit b822b85) Co-authored-by: Barney Gale <[email protected]>
GH-114464 is a backport of this pull request to the 3.12 branch. |
GH-114465 is a backport of this pull request to the 3.11 branch. |
….)` docs (GH-114035) (#114464) Clarify that *target_is_directory* only matters if the target doesn't exist. (cherry picked from commit b822b85) Co-authored-by: Barney Gale <[email protected]>
….)` docs (GH-114035) (#114465) Clarify that *target_is_directory* only matters if the target doesn't exist. (cherry picked from commit b822b85) Co-authored-by: Barney Gale <[email protected]>
…)` docs (python#114035) Clarify that *target_is_directory* only matters if the target doesn't exist.
…)` docs (python#114035) Clarify that *target_is_directory* only matters if the target doesn't exist.
Clarify that target_is_directory only matters if the target doesn't exist.
📚 Documentation preview 📚: https://cpython-previews--114035.org.readthedocs.build/