Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-114847: Speed up posixpath.realpath() #114848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 23 commits into from
Apr 5, 2024
Merged

GH-114847: Speed up posixpath.realpath() #114848

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
0a4f60a
GH-114847: Speed up `posixpath.realpath()`
barneygale Feb 1, 2024
5aa9c51
Tiny tweak
barneygale Feb 1, 2024
b758710
Slightly speed up handling of empty/dot parts
barneygale Feb 1, 2024
eb079b4
Merge branch 'main' into gh-114847
barneygale Mar 31, 2024
60d3bcb
Simplify '..' handling.
barneygale Mar 31, 2024
b849308
A few more perf improvements and simplifications.
barneygale Mar 31, 2024
085e105
Simplify symlink resolution signalling
barneygale Mar 31, 2024
69dabd2
Tiny tweaks
barneygale Mar 31, 2024
197c871
Spacing
barneygale Mar 31, 2024
b03e474
Merge branch 'main' into gh-114847
barneygale Apr 1, 2024
ecd1fe7
Comments
barneygale Apr 1, 2024
4b83c97
Final tweaks
barneygale Apr 1, 2024
77712d2
Further explain 'rest'.
barneygale Apr 1, 2024
15199a8
Update Lib/posixpath.py
barneygale Apr 2, 2024
8b3b808
Merge branch 'main' into gh-114847
barneygale Apr 2, 2024
01127e3
Merge branch 'main' into gh-114847
barneygale Apr 3, 2024
31955ee
Undo re-ordering of lstat() and seen lookup
barneygale Apr 3, 2024
211167e
Merge branch 'main' into gh-114847
barneygale Apr 3, 2024
fe62fef
Re-optimise link check
barneygale Apr 4, 2024
ebccd2b
Stop querying when `lstat()` fails.
barneygale Apr 4, 2024
d2a0248
Keep querying if we hit an OSError from lstat()
barneygale Apr 4, 2024
ecbb27c
Merge branch 'main' into gh-114847
barneygale Apr 4, 2024
eed739a
Update Lib/posixpath.py
barneygale Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tiny tweaks
  • Loading branch information
@barneygale
barneygale committed Mar 31, 2024
commit 69dabd2aa0860476e27f3a899e7f4e633dae0784
6 changes: 3 additions & 3 deletions Lib/posixpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ def realpath(filename, *, strict=False):
pardir = '..'
getcwd = os.getcwd

path = sep if filename.startswith(sep) else getcwd()
path = sep if filename[:1] == sep else getcwd()
rest = filename.split(sep)[::-1]
Comment thread
barneygale marked this conversation as resolved.
Comment thread
barneygale marked this conversation as resolved.
seen = {}
querying = True
Expand Down Expand Up @@ -463,7 +463,7 @@ def realpath(filename, *, strict=False):
# Return already resolved part + rest of the path unchanged.
path = newpath
querying = False
continue
continue
try:
st = os.lstat(newpath)
if not stat.S_ISLNK(st.st_mode):
Expand All @@ -479,7 +479,7 @@ def realpath(filename, *, strict=False):
continue

seen[newpath] = None # not resolved symlink
if target.startswith(sep):
if target[:1] == sep:
path = sep
rest.append(newpath)
rest.append(None)
Expand Down