Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-115015: Argument Clinic: fix generated code for METH_METHOD methods without args #115016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 5, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 5, 2024

TODO:

  • NEWS bugfix entry
  • prepare backports
  • add tests

@erlend-aasland
Copy link
Contributor Author

I'm not sure if we should list all affected methods in the news entry.

@erlend-aasland erlend-aasland changed the title gh-115015: Generate correct code for METH_METHOD methods without args gh-115015: Argument Clinic: fix generated code for METH_METHOD methods without args Feb 5, 2024
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 5, 2024
@serhiy-storchaka
Copy link
Member

@gvanrossum, you happen to be a codeowner of one of numerous generated files. I do not think that the review of any of the codeowners is required.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland erlend-aasland merged commit 09096a1 into python:main Feb 5, 2024
@erlend-aasland erlend-aasland deleted the clinic/fix-args-check branch February 5, 2024 20:49
@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews, Donghee and Serhiy!

@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2024

GH-115067 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 6, 2024
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Feb 6, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2024

GH-115069 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 6, 2024
erlend-aasland added a commit that referenced this pull request Feb 6, 2024
… methods without params (#115016) (#115067)

(cherry picked from commit 09096a1)
erlend-aasland added a commit that referenced this pull request Feb 6, 2024
… methods without params (#115016) (#115069)

(cherry picked from commit 09096a1)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants