-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-115421: Test that our Makefile has all needed test folders #115813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b04014f
gh-115421: Test that our Makefile has all needed test folders
sobolevn 5393647
Be silent
sobolevn f048fb5
Test PR that a missing `TESTSUBDIR` will fail
sobolevn f6c8639
Revert `test/archivetestdata` change
sobolevn 182822d
Better wording
sobolevn d192fbe
Fix buildbot failures
sobolevn 88e0f0c
Merge branch 'main' into issue-115421-2
sobolevn a743ffe
Do not run `make`, read file by lines
sobolevn 001c14b
Do not touch makefile at all
sobolevn 6caa8f9
Apply suggestions from code review
sobolevn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
""" | ||
Tests for `Makefile`. | ||
""" | ||
|
||
import os | ||
import unittest | ||
from test import support | ||
import sysconfig | ||
|
||
MAKEFILE = sysconfig.get_makefile_filename() | ||
|
||
if not support.check_impl_detail(cpython=True): | ||
raise unittest.SkipTest('cpython only') | ||
if not os.path.exists(MAKEFILE) or not os.path.isfile(MAKEFILE): | ||
raise unittest.SkipTest('Makefile could not be found') | ||
|
||
|
||
class TestMakefile(unittest.TestCase): | ||
def list_test_dirs(self): | ||
result = [] | ||
found_testsubdirs = False | ||
with open(MAKEFILE, 'r', encoding='utf-8') as f: | ||
for line in f: | ||
if line.startswith('TESTSUBDIRS='): | ||
found_testsubdirs = True | ||
result.append( | ||
line.removeprefix('TESTSUBDIRS=').replace( | ||
'\\', '', | ||
).strip(), | ||
) | ||
continue | ||
if found_testsubdirs: | ||
if '\t' not in line: | ||
break | ||
result.append(line.replace('\\', '').strip()) | ||
return result | ||
|
||
def test_makefile_test_folders(self): | ||
test_dirs = self.list_test_dirs() | ||
idle_test = 'idlelib/idle_test' | ||
self.assertIn(idle_test, test_dirs) | ||
|
||
used = [idle_test] | ||
for dirpath, _, _ in os.walk(support.TEST_HOME_DIR): | ||
dirname = os.path.basename(dirpath) | ||
if dirname == '__pycache__': | ||
continue | ||
|
||
relpath = os.path.relpath(dirpath, support.STDLIB_DIR) | ||
with self.subTest(relpath=relpath): | ||
self.assertIn( | ||
relpath, | ||
test_dirs, | ||
msg=( | ||
f"{relpath!r} is not included in the Makefile's list " | ||
"of test directories to install" | ||
) | ||
) | ||
used.append(relpath) | ||
|
||
# Check that there are no extra entries: | ||
unique_test_dirs = set(test_dirs) | ||
self.assertSetEqual(unique_test_dirs, set(used)) | ||
self.assertEqual(len(test_dirs), len(unique_test_dirs)) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.