GH-115802: JIT "small" code for macOS and Linux #115826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
markshannon
requested changes
Feb 26, 2024
| { | ||
| unsigned char rd = get_bits(loc32[0], 0, 5); | ||
| assert(IS_AARCH64_LDR_OR_STR(loc32[1])); | ||
| unsigned char rt = get_bits(loc32[1], 0, 5); |
There was a problem hiding this comment.
rt and rn are only used in the assert, so I'm getting an unused variable warning.
| assert(IS_AARCH64_LDR_OR_STR(loc32[1])); | ||
| unsigned char rt = get_bits(loc32[1], 0, 5); | ||
| unsigned char rn = get_bits(loc32[1], 5, 5); | ||
| assert(rd == rn && rn == rt); |
There was a problem hiding this comment.
Suggested change
| assert(rd == rn && rn == rt); | |
| assert(rd == get_bits(loc32[1], 5, 5) && rd == get_bits(loc32[1], 0, 5)); |
| @@ -121,21 +122,14 @@ async def _compile( | |||
| "-fno-builtin", | |||
| # SET_FUNCTION_ATTRIBUTE on 32-bit Windows debug builds: | |||
| "-fno-jump-tables", | |||
| # Position-independent code adds indirection to every load and jump: | |||
| "-fno-pic", | |||
| "-fno-plt", | |||
There was a problem hiding this comment.
Could you make sure each option has a comment saying what it does.
|
When you're done making the requested changes, leave the comment: |
|
Sorry, looks like I merged just before your review. I'll address these in the follow-up Windows PR. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows will come next, since that uses a different mechanism.
Somewhere in the neighborhood of ~0-3% faster, as expected.