gh-116316: Fix typo in UNARY_FUNC(PyNumber_Positive) macros
#116317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Good catch. Seems like this only affects the error message that gets thrown if a __pos__ method returns NULL without an exception or non-NULL with an exception, which can only happen with a poorly written C extension that overrides this slot. You can see it with this patch:
diff --git a/Objects/complexobject.c b/Objects/complexobject.c
index d8b0e84da5..b374c564af 100644
--- a/Objects/complexobject.c
+++ b/Objects/complexobject.c
@@ -577,6 +577,7 @@ complex_neg(PyComplexObject *v)
static PyObject *
complex_pos(PyComplexObject *v)
{
+ return NULL;
if (PyComplex_CheckExact(v)) {
return Py_NewRef(v);
}
Python 3.13.0a4+ (heads/pep696v2-dirty:a265008fa5, Mar 4 2024, 09:31:12) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> +1j
Fatal Python error: _Py_CheckSlotResult: Slot __pow__ of type complex failed without setting an exception
Python runtime state: initialized
Current thread 0x00000001f12f9e00 (most recent call first):
<no Python frame>
zsh: abort ./python.exe
|
Jelle, there's no need in backports :) |
|
Thanks, didn't realize this code changed recently. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNARY_FUNC(PyNumber_Positive)#116316