gh-129467: turn off false-positive -Wstringop-overflow in word_to_string() #116346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@vstinner, maybe you could review this little pr? Note, that 4.0.0 has more diagnostic ignored (at top of the file): #if defined(__GNUC__) && !defined(__INTEL_COMPILER) && __GNUC__ >= 7
#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
#pragma GCC diagnostic ignored "-Wmisleading-indentation"
#pragma GCC diagnostic ignored "-Warray-bounds"
#endifI turn of one diagnostic and more locally (with following pop directive).
|
libmpdec/ is vendored copy of a 3rd party project. You should fix the issue in the upstream first. Otherwise, it will be lost at the next update. See upstream: https://www.bytereef.org/mpdecimal/. |
|
Ok, then I close pr and issue. Unfortunately, @skrah blocked in python's repos. But he is aware about issue anyway. |
|
Merged, thank you. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
…ython#116346) Turn off false-positive -Wstringop-overflow in word_to_string().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main:writing 1 byte into a region of size 0 [-Wstringop-overflow=]#129467