Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump GitHub Actions #116944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Bump GitHub Actions #116944

merged 2 commits into from
Mar 18, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 18, 2024

In particular, updating https://github.com/pre-commit/action will fix this warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

https://github.com/python/cpython/actions/runs/8317266162

These are not upgraded by dependabot:

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
Copy link
Member Author

hugovk commented Mar 18, 2024

Before merging the backports, I'll update the other actions, because we've neglected backporting dependabot's PRs to bump actions/cache@v3 -> v4 etc. and we should keep those current too.

@hugovk hugovk enabled auto-merge (squash) March 18, 2024 07:30
@vstinner
Copy link
Member

vstinner commented Mar 18, 2024

I still see warnings at: https://github.com/python/cpython/actions/runs/8322739986?pr=116944

Check for source changes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Ana06/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@vstinner
Copy link
Member

Try:

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e36859e728..9e236534ae 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -97,7 +97,7 @@ jobs:
       - name: Get a list of the changed documentation-related files
         if: github.event_name == 'pull_request'
         id: changed-docs-files
-        uses: Ana06/[email protected]
+        uses: Ana06/[email protected]
         with:
           filter: |
             Doc/**

@hugovk hugovk disabled auto-merge March 18, 2024 07:43
@hugovk
Copy link
Member Author

hugovk commented Mar 18, 2024

Thanks, updated!

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit 3a99f5c into python:main Mar 18, 2024
@hugovk hugovk deleted the bump-github-actions branch March 18, 2024 08:44
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2024
(cherry picked from commit 3a99f5c)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 18, 2024

GH-116948 is a backport of this pull request to the 3.12 branch.

@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3a99f5c5f34dc7b67597ca7230da355d92927c71 3.11

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 18, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 18, 2024

GH-116949 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 18, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 18, 2024
(cherry picked from commit 3a99f5c)

Co-authored-by: Hugo van Kemenade <[email protected]>
ambv pushed a commit that referenced this pull request Mar 19, 2024
(cherry picked from commit 3a99f5c)

Co-authored-by: Hugo van Kemenade <[email protected]>
ambv pushed a commit that referenced this pull request Mar 19, 2024
(cherry picked from commit 3a99f5c)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk
Copy link
Member Author

hugovk commented Mar 19, 2024

They just released 0.6.1 with Node.js v20.

Let's update it whenever, no particular rush, and we don't usually look at the logs of that workflow.

vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants