Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-117110: Fix subclasses of typing.Any with custom constructors #117111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 5 commits into from
Mar 29, 2024
Merged

gh-117110: Fix subclasses of typing.Any with custom constructors #117111

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb230b0
Fixes #117110
Azureblade3808 Mar 21, 2024
4e889b8
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 21, 2024
697aa2b
Add a test that subclass of `Any` should be able to instantiate with …
Azureblade3808 Mar 21, 2024
6017956
move test and add a second test
AlexWaygood Mar 21, 2024
0d96604
Merge branch 'main' into patch-1
Azureblade3808 Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,12 @@ def test_any_works_with_alias(self):
typing.Pattern[Any]
typing.IO[Any]

def test_subclass_can_instantiate_with_arguments(self):
class Sub(Any):
def __init__(self, *args, **kwargs): pass
# The instantiation must not fail.
Sub(0, s="")


class BottomTypeTestsMixin:
bottom_type: ClassVar[Any]
Expand Down
2 changes: 1 addition & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ class Any(metaclass=_AnyMeta):
def __new__(cls, *args, **kwargs):
if cls is Any:
raise TypeError("Any cannot be instantiated")
return super().__new__(cls, *args, **kwargs)
return super().__new__(cls)


@_SpecialForm
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-03-21-07-27-36.gh-issue-117110.9K1InX.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug that prevents subclasses of :class:`typing.Any` to be instantiated with arguments. Patch by Chris Fu.