Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-117225: doctest: only print "and X failed" when non-zero, don't pluralise "1 items" #117228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 6 commits into from
Mar 27, 2024
Merged

gh-117225: doctest: only print "and X failed" when non-zero, don't pluralise "1 items" #117228

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e1f57f
Only print 'and X failed' when non-zero
hugovk Mar 24, 2024
699b33d
Do not pluralise 1 item
hugovk Mar 24, 2024
cb4d8d2
Refactor summarize()
hugovk Mar 24, 2024
a684423
Update docs
hugovk Mar 24, 2024
266081e
Add blurb
hugovk Mar 25, 2024
4c1efb6
Update test: '1 failures' -> '1 failure'
hugovk Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor summarize()
  • Loading branch information
@hugovk
hugovk committed Mar 25, 2024
commit cb4d8d2fe6d45c1f08a41e403699651fc6bfda63
18 changes: 8 additions & 10 deletions Lib/doctest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,22 +1568,22 @@ def summarize(self, verbose=None):
"""
if verbose is None:
verbose = self._verbose
notests = []
passed = []
failed = []

notests, passed, failed = [], [], []
total_tries = total_failures = total_skips = 0
for item in self._stats.items():
name, (failures, tries, skips) = item

for name, (failures, tries, skips) in self._stats.items():
assert failures <= tries
total_tries += tries
total_failures += failures
total_skips += skips

if tries == 0:
notests.append(name)
elif failures == 0:
passed.append((name, tries))
else:
failed.append(item)
failed.append((name, (failures, tries, skips)))

if verbose:
if notests:
Expand All @@ -1594,16 +1594,14 @@ def summarize(self, verbose=None):

if passed:
print(f"{_n_items(passed)} passed all tests:")
passed.sort()
for name, count in passed:
for name, count in sorted(passed):
s = "" if count == 1 else "s"
print(f" {count:3d} test{s} in {name}")

if failed:
print(self.DIVIDER)
print(f"{_n_items(failed)} had failures:")
failed.sort()
for name, (failures, tries, skips) in failed:
for name, (failures, tries, skips) in sorted(failed):
print(f" {failures:3d} of {tries:3d} in {name}")

if verbose:
Expand Down