Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-117459: Keep the traceback in _convert_future_exc #117460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 5 commits into from
Apr 4, 2024
Merged

gh-117459: Keep the traceback in _convert_future_exc #117460

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
beb04c5
Persist traceback for _convert_future_exc
rsp4jack Apr 2, 2024
1e285ac
Add regression test for #117459
rsp4jack Apr 2, 2024
a3dfaee
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 2, 2024
f4a6308
Merge branch 'main' into main
rsp4jack Apr 2, 2024
214f793
Remove redundant check for TimeoutError
rsp4jack Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove redundant check for TimeoutError 
As #117459 (comment) said, TimeoutError is a builtin exception now
  • Loading branch information
@rsp4jack
rsp4jack committed Apr 3, 2024
commit 214f7934ae4db7e7dd32e76a038a4332fa59b8bf
2 changes: 0 additions & 2 deletions Lib/asyncio/futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,6 @@ def _convert_future_exc(exc):
exc_class = type(exc)
if exc_class is concurrent.futures.CancelledError:
return exceptions.CancelledError(*exc.args).with_traceback(exc.__traceback__)
elif exc_class is concurrent.futures.TimeoutError:
return exceptions.TimeoutError(*exc.args).with_traceback(exc.__traceback__)
elif exc_class is concurrent.futures.InvalidStateError:
return exceptions.InvalidStateError(*exc.args).with_traceback(exc.__traceback__)
else:
Expand Down