Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-117348: restore import time performance of configparser #117703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 5 commits into from
Apr 14, 2024
Merged

gh-117348: restore import time performance of configparser #117703

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8091be3
Get Iterable from collections.abc.
jaraco Apr 9, 2024
7de4e00
Replace dataclass with SimpleNamespace.
jaraco Apr 10, 2024
11bae33
Add blurb
jaraco Apr 10, 2024
24c0705
Remove SimpleNamespace from _ReadState, as it adds no value.
jaraco Apr 14, 2024
456de13
Use SimpleNamespace inline.
jaraco Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace dataclass with SimpleNamespace. 
Reduces import time by over 50% (10431µs vs 4350µs on Apple M3 Pro).
  • Loading branch information
@jaraco
jaraco committed Apr 10, 2024
commit 7de4e0045b9d6574492291be07ef21a5171e2787
18 changes: 11 additions & 7 deletions Lib/configparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,16 +143,18 @@
between keys and values are surrounded by spaces.
"""

# Do not import dataclasses; overhead is unacceptable (gh-117703)

from collections.abc import Iterable, MutableMapping
from collections import ChainMap as _ChainMap
import contextlib
from dataclasses import dataclass, field
import functools
import io
import itertools
import os
import re
import sys
import types

__all__ = ("NoSectionError", "DuplicateOptionError", "DuplicateSectionError",
"NoOptionError", "InterpolationError", "InterpolationDepthError",
Expand Down Expand Up @@ -537,19 +539,21 @@ def _interpolate_some(self, parser, option, accum, rest, section, map,
"found: %r" % (rest,))


@dataclass
class _ReadState:
elements_added : set[str] = field(default_factory=set)
class _ReadState(types.SimpleNamespace):
elements_added : set[str]
cursect : dict[str, str] | None = None
sectname : str | None = None
optname : str | None = None
lineno : int = 0
indent_level : int = 0
errors : list[ParsingError] = field(default_factory=list)
errors : list[ParsingError]

def __init__(self):
self.elements_added = set()
self.errors = list()


@dataclass
class _Prefixes:
class _Prefixes(types.SimpleNamespace):
full : Iterable[str]
inline : Iterable[str]

Expand Down