gh-118416: Fix possible etree issues when registering default namespaces - #118417
Closed
danifus wants to merge 1 commit into
Closed
gh-118416: Fix possible etree issues when registering default namespaces#118417danifus wants to merge 1 commit into
danifus wants to merge 1 commit into
Conversation
…ces in ElementTree In some circumstances, registering a default namespace (`""`) with `xml.etree.ElementTree.register_namespace` could result in serialising incorrect xml
Contributor
Author
|
Closing this PR as I would rather merge in a solution that is based on this refactor: #120772 I've implemented this fix on a local branch built on that refactor. That branch fixes a few issues as they all modify the same section of code. I'll split that branch into PRs which address one issue at a time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some circumstances, registering a default namespace prefix (
"") withxml.etree.ElementTree.register_namespacecould result in serialising incorrect xml"") with register_namespace has issues #118416📚 Documentation preview 📚: https://cpython-previews--118417.org.readthedocs.build/