Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-118647: Add defaults to typing.Generator and typing.AsyncGenerator #118648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 4 commits into from
May 6, 2024
Merged

gh-118647: Add defaults to typing.Generator and typing.AsyncGenerator #118648

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ddde9d
gh-118647: Add defaults to typing.Generator and typing.AsyncGenerator
JelleZijlstra May 6, 2024
5931094
Fix test, add blurb
JelleZijlstra May 6, 2024
682f643
Apply suggestions from code review
JelleZijlstra May 6, 2024
8a3d16d
Apply suggestions from code review
JelleZijlstra May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test, add blurb
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed May 6, 2024
commit 59310943becad11f336a3f7e1219b4e93b9ee73f
2 changes: 1 addition & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@ def __getattr__(self, attr):
raise AttributeError(attr)

def __setattr__(self, attr, val):
if _is_dunder(attr) or attr in {'_name', '_inst', '_nparams'}:
if _is_dunder(attr) or attr in {'_name', '_inst', '_nparams', '_defaults'}:
super().__setattr__(attr, val)
else:
setattr(self.__origin__, attr, val)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-05-06-08-23-01.gh-issue-118648.OVA3jJ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add type parameter defaults to :class:`typing.Generator` and
:class:`typing.AsyncGenerator`.