gh-118527: Intern code consts in free-threaded build #118667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already intern and immortalize most string constants. In the free-threaded build, other constants can be a source of reference count contention because they are shared by all threads running the same code objects.
|
!buildbot nogil |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 5e8c0f0 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
DinoV
reviewed
May 6, 2024
DinoV
reviewed
May 6, 2024
colesbury
commented
May 6, 2024
| else if (PyTuple_CheckExact(op)) { | ||
| Py_ssize_t size = PyTuple_GET_SIZE(op); | ||
| PyObject **data = _PyTuple_ITEMS(op); | ||
| return _Py_HashBytes(data, sizeof(PyObject *) * size); |
There was a problem hiding this comment.
We first intern and de-dupe the contents so identity comparisons (including hasing pointers) is sufficient.
For example the following prints True with this PR:
def foo():
return (0.0, (1, 2, "hello"))
def bar():
return (0.0, (1, 2, "hello"))
print(foo() is bar())
DinoV
approved these changes
May 6, 2024
|
!buildbot nogil |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit f5cab78 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…8667) We already intern and immortalize most string constants. In the free-threaded build, other constants can be a source of reference count contention because they are shared by all threads running the same code objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already intern and immortalize most string constants. In the free-threaded build, other constants are a frequent source of reference count contention because they are shared by all threads running the same code objects.
For example, the following function would not otherwise scale because
1.5would be a non-immortalized constant shared by all threads that executerun_in_parallel.