Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-36004: Add date.fromisocalendar #11888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 29, 2019
Merged

bpo-36004: Add date.fromisocalendar #11888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6d323ad
Add date.fromisocalendar and tests
pganssle Feb 15, 2019
fbab728
Add early year check to fromisocalendar
pganssle Feb 17, 2019
925de2f
Covert OverflowError into ValueError
pganssle Feb 17, 2019
3ecf02e
Add bounds checking for ISO long vs. short weeks
pganssle Feb 17, 2019
e645cd0
Add more comments with test cases
pganssle Feb 17, 2019
86edee5
Switch to new method of detecting ISO long years
pganssle Feb 17, 2019
74fb523
Fix missing argument in PyErr_Format
pganssle Feb 17, 2019
46c6458
Add test for TypeError handling
pganssle Feb 17, 2019
28c7fb2
Add documentation for date(time).fromisocalendar
pganssle Feb 17, 2019
99e75d7
Add NEWS entry
pganssle Feb 17, 2019
c269a5c
Add What's New entry for fromisocalendar
pganssle Mar 17, 2019
c8444b7
Use MINYEAR and MAXYEAR in bounds checks
pganssle Apr 29, 2019
958ffff
Add tests for MINYEAR and MAXYEAR
pganssle Apr 29, 2019
3307865
Use generated test cases instead of manual list
pganssle Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use MINYEAR and MAXYEAR in bounds checks
  • Loading branch information
@pganssle
pganssle committed Apr 29, 2019
commit c8444b70f18a6fb9a157c942a07d61f6c3aea8a0
2 changes: 1 addition & 1 deletion Lib/datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ def fromisocalendar(cls, year, week, day):

This is the inverse of the date.isocalendar() function"""
# Year is bounded this way because 9999-12-31 is (9999, 52, 5)
if not 0 < year < 10000:
if not MINYEAR <= year <= MAXYEAR:
raise ValueError(f"Year is out of range: {year}")

if not 0 < week < 53:
Expand Down
2 changes: 1 addition & 1 deletion Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3024,7 +3024,7 @@ date_fromisocalendar(PyObject *cls, PyObject *args, PyObject *kw)
}

// Year is bounded to 0 < year < 10000 because 9999-12-31 is (9999, 52, 5)
if (year <= 0 || year >= 10000) {
if (year < MINYEAR || year > MAXYEAR) {
PyErr_Format(PyExc_ValueError, "Year is out of range: %d", year);
return NULL;
}
Expand Down